Improve CLI for owners in bash tests #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
changed the title
afck
approved these changes
Feb 22, 2025
deuszx
reviewed
Feb 22, 2025
| @@ -1118,6 +1119,7 @@ impl Runnable for Job { | |||
| println!("{}", outcome.chain_id); | |||
| println!("{}", outcome.message_id); | |||
| println!("{}", outcome.certificate_hash); | |||
| println!("{}", owner); | |||
There was a problem hiding this comment.
Just by looking at these printlns it's impossible to tell "what is what". Is it so b/c this format is easier to consume programmatically?
There was a problem hiding this comment.
That's right. Eventually we should have (small?) libraries in non-bash scripting languages for this
There was a problem hiding this comment.
We could also use JSON but then we need jq in bash
deuszx
approved these changes
Feb 22, 2025
ma2bd
force-pushed
the
linera_cli_owners
branch
from
5934341 to
6ae1bac
Compare
ma2bd
commented
Feb 22, 2025
|
|
||
| linera wallet init --faucet $FAUCET_URL | ||
|
|
||
| INFO_1=($(linera wallet request-chain --faucet $FAUCET_URL)) |
There was a problem hiding this comment.
Do we prefer INFO1 or INFO_1 in general?
There was a problem hiding this comment.
I'm fine with both. No opinions here.
ma2bd
force-pushed
the
linera_cli_owners
branch
from
6ae1bac to
d706a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow removing the hard-coded OWNER variables from README tests
Proposal
Make sure to return the owner on stdout every time the CLI generates a key pair.
Test Plan
I modified the main README file.
Links
Continues #3385