Add Secp256k1 keys #3345
Merged
Add Secp256k1 keys #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
deuszx
force-pushed
the
secp256k1-keys
branch
from
70dcae4 to
45afae9
Compare
deuszx
force-pushed
the
secp256k1-keys
branch
from
4de29aa to
77e4ef9
Compare
deuszx
force-pushed
the
secp256k1-keys
branch
from
77e4ef9 to
8a00754
Compare
deuszx
changed the base branch from
main
to
refactor-separate-authority-account-keys
afck
reviewed
Feb 19, 2025
|
|
||
| impl fmt::Debug for Secp256k1PublicKey { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| write!(f, "{}", hex::encode(&self.0.serialize()[0..9])) |
There was a problem hiding this comment.
What would self.0.fmt(f) look like? I'd expect that to also just be the key in hexadecimal?
Base automatically changed from
refactor-separate-authority-account-keys
to
main
February 19, 2025 14:27
deuszx
force-pushed
the
secp256k1-keys
branch
3 times, most recently
from
f8ad395 to
60e38eb
Compare
afck
reviewed
Feb 19, 2025
deuszx
force-pushed
the
secp256k1-keys
branch
from
60e38eb to
23c9173
Compare
afck
approved these changes
Feb 19, 2025
deuszx
force-pushed
the
secp256k1-keys
branch
2 times, most recently
from
49ab7e9 to
5314f7c
Compare
deuszx
changed the base branch from
main
to
refactor-use-pk-instead-of-owner
deuszx
force-pushed
the
refactor-use-pk-instead-of-owner
branch
3 times, most recently
from
07d9ca9 to
3c76e1e
Compare
deuszx
force-pushed
the
secp256k1-keys
branch
from
5314f7c to
1daf7c9
Compare
deuszx
force-pushed
the
refactor-use-pk-instead-of-owner
branch
from
3c76e1e to
9293417
Compare
deuszx
force-pushed
the
secp256k1-keys
branch
2 times, most recently
from
6a12891 to
d37befd
Compare
deuszx
force-pushed
the
secp256k1-keys
branch
from
d37befd to
b79881f
Compare
ma2bd
added a commit
that referenced
this pull request
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support secp256k1 signatures - meaning we need public/pivate keys for them.
Proposal
Adds
Secp256k1SecretKeyandSecp256k1PublicKeystructs. Creates a staticSECP256K1context for reuse, instead of initializing new context for every operation. Note that the same effect could be used by usingglobal-contextfeature of thesecp256k1crate but that is mutually exclusive with other features (likealloc) that we might want to use in the future.Test Plan
N/A
Release Plan