Implement very basic widget inspector #820
Conversation
| let (widget, state) = self.render_root.widget_arena.get_pair(widget_id); | ||
| let widget_name = widget.item.short_type_name(); | ||
| let display_name = if let Some(debug_text) = widget.item.get_debug_text() { | ||
| format!("{widget_name}<{debug_text}>") |
There was a problem hiding this comment.
This is unfortunately sparse for a lot of widgets. I suppose that makes a good follow-up?
There was a problem hiding this comment.
Yes, I think I'll leave the exact format to a future follow-up. It can be a very self-contained future PR.
masonry/src/event_loop_runner.rs
Outdated
| widget_name.into() | ||
| }; | ||
| println!("Widget selected in inspector: {widget_id} - {display_name}"); | ||
| println!("{:#?}", state.item); |
There was a problem hiding this comment.
Whereas this is extremely large. I don't necessarily think there's anything we can do about it though...
| }; | ||
| println!("Widget selected in inspector: {widget_id} - {display_name}"); | ||
| println!("{:#?}", state.item); | ||
| } |
There was a problem hiding this comment.
There would be reasonable arguments for printing the broad shape of the children tree as well. Not necessarily the full widget state, but the names and debug text. Maybe? limited to a certain depth(/length?)
PoignardAzur
force-pushed
the
add_inspector_2
branch
from
e40d86d to
f282633
Compare
|
Will probably merge tomorrow. |
|
I do agree with Daniel that some documentation in the README would be good. I needed to scan the code to find out how to use this. |
| ### Debugging features | ||
|
|
||
| Masonry apps currently ship with two debugging features built in: | ||
| - A rudimentary widget inspector - toggled by F11 key. |
There was a problem hiding this comment.
| - A rudimentary widget inspector - toggled by F11 key. | |
| - A rudimentary widget inspector - activated by F11 key. |
There was a problem hiding this comment.
Technically it can be toggled off with the key.
There was a problem hiding this comment.
I think "toggled" is right.
|
Do you think the Ubuntu failure has anything to do with Github Actions' switch from Ubuntu 22 to 24? |
|
@jaredoconnell Yes, and it is fixed on |
|
Alright, I'll rebase. |
PoignardAzur
force-pushed
the
add_inspector_2
branch
from
73ea94e to
87ba6af
Compare
No description provided.