Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PresentMode::Mailbox when available. #712

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xorgy
Copy link
Member

@xorgy xorgy commented Oct 22, 2024

This provides much better latency by default on X11 and Wayland.

This provides much better latency by default on X11 and Wayland.
@xorgy xorgy force-pushed the vello-0.2-use-mailbox-when-available branch from 45d3bce to 92b622a Compare October 22, 2024 18:15
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is listed as a NoVsync mode in wgpu's docs. We kind of do want vsync behaviour for our use case, because power efficiency is something we want to at least aim for.
I presume you've confirmed that this doesn't lead to more frames than are displayed being rendered?

@xorgy xorgy marked this pull request as draft October 22, 2024 19:08
@xorgy
Copy link
Member Author

xorgy commented Oct 22, 2024

I presume you've confirmed that this doesn't lead to more frames than are displayed being rendered?

No, I meant this to show what latency is left on the table for interactions by not rendering immediately. By default Fifo and FifoRelaxed introduce a lot of latency even on systems with plenty of throughput. In practice, when we have animations in the mix, we have to be limiting somehow.

@xorgy
Copy link
Member Author

xorgy commented Oct 22, 2024

Probably there's a middle ground where we configure the FIFO. Floem always uses FIFO, but asks wgpu to try to limit the depth to two frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants