Taffy integration #682
Draft
Taffy integration #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of the taffy integration code.
The Masonry widget is based on the widget originally merged in #140, so I included Nico as a co-author of the relevant commit in this PR.
Working on this exposed several limitations of the current layout function. We need a measure function. It would be beneficial to switch to a combination of a layout and measure function with new signatures that include more information, which could replace the min constraints in BoxConstraints. Nico made a proposal in #37
This may stay a draft until a suitable measure function is added in a separate PR.