Add public methods to access clip path #622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds public getters for clip path to non-
LayoutCtx
contexts, and also toWidgetState
as it seems relevant for painting.The motivation is to remove private field accesses from
Widget::get_child_at_pos
as mentioned in#565 (comment).
This leaves one private field access, namely
WidgetState::is_stashed
. As per the docs ofWidgetState
("widgets will generally not interact with it directly"), that field perhaps should not be publicly accessible fromWidgetState
, but then it should be accessible fromWidgetRef
.