Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about mutable child state in WidgetState::merge_up #618

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add note about mutable child state in WidgetState::merge_up #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions masonry/src/widget/widget_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,11 @@ impl WidgetState {

/// Update to incorporate state changes from a child.
///
/// This will also clear some requests in the child state.
///
/// This method is idempotent and can be called multiple times.
//
// TODO: though this method takes child state mutably, child state currently isn't actually
// mutated anymore. This method may start doing so again in the future, so keep taking &mut for
// now.
pub(crate) fn merge_up(&mut self, child_state: &mut WidgetState) {
self.needs_layout |= child_state.needs_layout;
self.needs_compose |= child_state.needs_compose;
Expand Down