Re-arrange flex.rs file to match format of other widgets
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Github's diff view makes it extremely hard to determine if there's any change in behaviour here, so I'm choosing to defer reviewing this.
I also disagree with the primary change of not having the Flex and WidgetMut<Flex> impls be next to each other. The other re-orderings are probably an improvement.
|
For what it's worth I did strict cut-and paste, there really shouldn't be behavior changes. |
DJMcNab
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.