Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xilem example for http cats API, requiring workers and image component #571

Merged
merged 13 commits into from
Sep 3, 2024
Merged

Xilem example for http cats API, requiring workers and image component #571

merged 13 commits into from
Sep 3, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 3, 2024 •
edited
Loading

This example is inspired by: https://troz.net/post/2024/swiftui-mac-2024/

Current status:

  • Lists status code
  • Can select status code
  • Downloads image from status code
  • Shows image from status code

This adds two new features to Xilem:

  • The worker view, which is the obvious extension to task for multiple operations
  • The image view, which just uses Masonry Image.

It also fixes a the Masonry Image view's layout to use the already extant but unused method.

jaredoconnell
jaredoconnell reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Tested.

@DJMcNab DJMcNab changed the title Xilem example which access the http cats API Xilem example for http cats API, requiring workers and image component Sep 3, 2024
@DJMcNab DJMcNab marked this pull request as ready for review September 3, 2024 16:17
jaredoconnell
jaredoconnell approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It works as intended. I have only one comment.

xilem/examples/http_cats/main.rs Outdated Show resolved Hide resolved
@DJMcNab DJMcNab changed the title Xilem example for http cats API, requiring workers and image component Xilem example for http cats API, requiring workers and image component Sep 3, 2024
jaredoconnell
jaredoconnell approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. This'll be a nice addition.

@DJMcNab DJMcNab added this pull request to the merge queue Sep 3, 2024
Merged via the queue into linebender:main with commit 7be4dd2 Sep 3, 2024
17 checks passed
@DJMcNab DJMcNab deleted the http_cats branch September 3, 2024 19:08
@DJMcNab DJMcNab mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys left review comments

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJMcNab @waywardmonkeys @jaredoconnell