Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a small emoji picker/selector example #420

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add a small emoji picker/selector example #420

wants to merge 10 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jul 1, 2024 •
edited
Loading

This depends on:

I have added those as our dependencies; it's unlikely that a release containing those will happen very soon.

Xilem Emoji Picker.

Some notes:

  1. The accessibility of this example probably isn't great. Not sure what to do about this.
  2. Our layout primitives aren't great; I've hacked around a grid layout, but we really need to make a Grid widget/View
  3. The pagination is slightly hacked together - it should really try and give you page numbers. I'm not planning to address this, unless someone provides the algorithm
  4. Emoji only render on systems with a system COLR Emoji font. I know my Android device does, but I don't know if any other systems do? Maybe Windows and some Linux systems? This blocks this PR

This is created for linebender/linebender.github.io#56

@jaredoconnell
Copy link
Contributor

I tested this, and the fonts are not visible on Mac OS. Maybe the font isn't COLR format.

@DJMcNab
Copy link
Member Author

DJMcNab commented Jul 3, 2024

Indeed. This is called out in linebender/linebender.github.io#56, for example.

@DJMcNab DJMcNab marked this pull request as draft July 18, 2024 10:16
@DJMcNab
Copy link
Member Author

DJMcNab commented Jul 18, 2024

Moving this into draft due to the lack of bitmap emoji support.

@DJMcNab
Copy link
Member Author

DJMcNab commented Oct 29, 2024 •
edited
Loading

This should start working properly once we have Vello 0.3 and Parley 0.2. See #616

@DJMcNab DJMcNab mentioned this pull request Nov 6, 2024
Open
@DJMcNab DJMcNab mentioned this pull request Nov 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2024
@DJMcNab
Update to Vello 0.3.0, Parley main, AccessKit 0.17 (#616)
10dc9d1 
The biggest remaining issue in this PR is that IME support is not
present.

However, I think landing this is *better* than not landing it, because:
1) If we don't land it, it's going to languish again
2) Getting IME support back can be parallelised (cc @tomcur)
3) Getting Vello 0.3.0 and Parley 0.2.0 unlocks real advantages,
including full emoji support (#420).

To be clear, my first follow-up priority will be connecting the IME back
up. I do not however think this should block on Parley 0.3.0.

Discussion in
https://xi.zulipchat.com/#narrow/channel/317477-masonry/topic/Updating.20Parley.20dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJMcNab @jaredoconnell