Address review comments

linebender · Sep 11, 2024 · 5bab9c7 · 5bab9c7
1 parent cb8e984
commit 5bab9c7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/masonry/examples/grid_masonry.rs b/masonry/examples/grid_masonry.rs
@@ -45,8 +45,7 @@ fn grid_button(params: GridParams) -> Button {
 pub fn main() {
     let label = SizedBox::new(
         Prose::new(
-            "Change spacing by right and \
-                               left clicking on the buttons",
+            "Change spacing by right and left clicking on the buttons",
         )
         .with_text_size(14.0)
         .with_text_alignment(Alignment::Middle),

diff --git a/masonry/src/widget/grid.rs b/masonry/src/widget/grid.rs
@@ -354,6 +354,13 @@ mod tests {
             grid.set_spacing(7.0);
         });
         assert_render_snapshot!(harness, "with_changed_spacing");
+
+        // Make the spacing negative
+        harness.edit_root_widget(|mut grid| {
+            let mut grid = grid.downcast::<Grid>();
+            grid.set_spacing(-4.0);
+        });
+        assert_render_snapshot!(harness, "with_negative_spacing");
     }
 
     #[test]

diff --git a/.../src/widget/screenshots/masonry__widget__grid__tests__with_negative_spacing.png b/.../src/widget/screenshots/masonry__widget__grid__tests__with_negative_spacing.png