Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WGPU_BACKEND and simplify shader util function #462

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

DasLixou
Copy link
Collaborator

Two mini patches:

  • making the read_draw_tag_from_scene wgsl function more equal to it's cpu equivalent, just from guessing I think this would safe 2 cycles (because 2 add operations are now either 0 or 1) but that's too much of a microoptimization, I just like to think about that.
  • Taking WGPU_BACKEND env variable into selection of the backend, which enables me to get rid of the dx12 error spam mentioned in Artifacts on Windows with GPU #449 and also bumps my fps from 80-85 on dx12 to 100-120 on vulkan.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, both of these look good.

I've also tested the backend selection locally, and was able to get the gles backend working with no apparent compromises

@DJMcNab DJMcNab changed the title Some mini patches (two to be exact) Support WGPU_BACKEND and simplify shader util function Feb 26, 2024
@DJMcNab DJMcNab added this pull request to the merge queue Feb 26, 2024
Merged via the queue into linebender:main with commit ffa808a Feb 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants