-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splinetoy + wasm #13
Open
cmyr
wants to merge
39
commits into
main
Choose a base branch
from
wasm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
splinetoy + wasm #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- supress click when handled by toolbar - fix swapped placeholder auto point position - treat trailing point as auto
This is common UX in tools like this; shift+click with the pen tool aligns the point with the previous point. Similar behaviour is added for dragging and adjusting handles.
This doesn't combine the first/last points when a path is closed, but otherwise seems to work okay.
This does the trick where a single point represents both the first 'moveto' and the final lineto/splineto point.
- fix crash when deleting first point - remove empty paths after removing last point
- this also fixes a crash when adding a point to an open path
This will let us easily deploy the toy on the web.
This will be useful for demos.
shift+s will now cause us to attempt to save the current data as a base64 encoded query string. This should work okay for small numbers of points, but will fail at some point.
- our data format is now versioned - data on web is saved to the anchor - selected tool is part of save data
The debug menu will let us making links that lock the app in select mode, and hide the menubar.
The previous logic would let us get into an invalid state and crash on the next `move_to`, as the solver had existing elements
(this is based on eli's recent runebender patch) - linebender/runebender#191
This also makes sure that we move control points when we move on-curve points.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a dump of all the code used in the hyperbezier demos. If you want to add me on crates.io I can do a release.