Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the CI cargo fmt job to formatting. #59

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Nov 1, 2024

This brings the CI in sync with the latest Linebender standard, see e.g. xilem.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, was the cargo fmt job not previously required in this repository?

@xStrom
Copy link
Member Author

xStrom commented Nov 1, 2024

Hmm, was the cargo fmt job not previously required in this repository?

Indeed it was. I just removed that requirement in preparation for this to be merged. 🚀

@DJMcNab
Copy link
Member

DJMcNab commented Nov 1, 2024

For reference, I normally swap the requirements just before merging, i.e. once the PR making the change is approved.

Practically though, that's only a small difference

@xStrom xStrom added this pull request to the merge queue Nov 1, 2024
Merged via the queue into linebender:main with commit 444dd3b Nov 1, 2024
15 checks passed
@xStrom xStrom deleted the formatting branch November 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants