Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ignore-unknown-features to the CI. #58

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add --ignore-unknown-features to the CI. #58

merged 2 commits into from
Oct 31, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Oct 31, 2024

Having this flag enables the CI to continue working if the workspace gets a package that doesn't have e.g. the std feature.

This brings it in sync with the latest Linebender standard, see e.g. parley.

DJMcNab
DJMcNab approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this being a footgun when we get color; thanks.

@xStrom xStrom added this pull request to the merge queue Oct 31, 2024
Merged via the queue into linebender:main with commit af59df8 Oct 31, 2024
15 checks passed
@xStrom xStrom deleted the ignoreunknown branch October 31, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xStrom @waywardmonkeys @DJMcNab