Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fontconfig-cache-parser #36

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Apr 20, 2024

This cuts down on transitive dependencies by moving things to dev-dependencies.

It also marked the Object enum as #[non_exhaustive], hence the version bump.

@jneem jneem requested a review from DJMcNab April 20, 2024 01:58
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

(But should we change the MSRV back a few versions now that clap isn't forcing it to be so recent?)

@jneem jneem added this pull request to the merge queue Apr 20, 2024
Merged via the queue into linebender:main with commit 27bf853 Apr 20, 2024
19 checks passed
@jneem jneem deleted the bump-fontconfig-cache-parser branch April 20, 2024 03:12
@DJMcNab
Copy link
Member

DJMcNab commented Apr 20, 2024

I think that this pr should probably have included the MSRV decrease, if this was the only blocker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants