Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about MSRV compile failure. #35

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Apr 19, 2024

This PR adds the note about how to deal with MSRV compilation failures. I optimistically didn't add it in #33 because the Rust toolchain can give basically the same instructions:

error: package `peniko v0.1.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.1
Either upgrade to rustc 1.70 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `peniko` supporting rustc 1.67.1

However this nice error message is only given if rust-version is correctly specified by the dependency. In other cases it will be some much more obscure error about the specific code that can't be handled.

Given that we hide these instructions behind <details/> it won't cause too much noise and can be helpful in those obscure error scenarios.

@xStrom
Copy link
Member Author

xStrom commented Apr 19, 2024

Turns out that on Linux the MSRV is actually 1.74 due to clap_derive v4.5.4. I did my initial MSRV checks on Windows, where parley can be compiled with 1.70. Other than that this first actual CI run was green.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really shouldn't be depending on clap_derive, but I've started the thread for that in Zulip

@xStrom xStrom added this pull request to the merge queue Apr 19, 2024
Merged via the queue into linebender:main with commit 86b1f07 Apr 19, 2024
19 checks passed
@xStrom xStrom deleted the msrvnote branch April 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants