Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PlainEditor width Option<f32> #137

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Make PlainEditor width Option<f32> #137

merged 1 commit into from
Oct 11, 2024

Conversation

nicoburns
Copy link
Contributor

This matches Layout, and is useful for single-line text inputs that shouldn't ever wrap.

@nicoburns nicoburns added the bug Something isn't working label Oct 11, 2024
@nicoburns nicoburns requested a review from xorgy October 11, 2024 02:25
@nicoburns
Make PlainEditor width Option<f32>
e6fc98d 
This matches `Layout`, and is useful for single-line text inputs
that shouldn't ever wrap.
waywardmonkeys
waywardmonkeys approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if there should be tests to make sure the desired behavior happens. Probably should be on Layout though if we don't already have them.

@nicoburns nicoburns added this pull request to the merge queue Oct 11, 2024
Merged via the queue into linebender:main with commit 352df19 Oct 11, 2024
20 checks passed
@nicoburns nicoburns deleted the editor-optional-width branch October 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

@xorgy xorgy Awaiting requested review from xorgy

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @waywardmonkeys