Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Parley and Fontique 0.2.0 #130

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

xorgy
Copy link
Member

@xorgy xorgy commented Oct 10, 2024

No description provided.

@xorgy xorgy added this to the 0.2 Release milestone Oct 10, 2024
@xorgy xorgy force-pushed the release-0.2.0 branch 3 times, most recently from bdef388 to 9c2405d Compare October 10, 2024 16:18
@xorgy xorgy added this pull request to the merge queue Oct 10, 2024
Merged via the queue into linebender:main with commit 1adcf99 Oct 10, 2024
20 checks passed
@xorgy xorgy deleted the release-0.2.0 branch October 10, 2024 16:32
@@ -1,6 +1,6 @@
[package]
name = "fontique"
version = "0.1.0" # Keep in sync with workspace dependency specification
version = "0.2.0" # Keep in sync with workspace dependency specification
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use version.workspace = true

Copy link
Member Author

@xorgy xorgy Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is likely we end up releasing Fontique less often than Parley. For example I can't think of any breaking changes proposed for Fontique before Parley 0.3 right now. The fact that they both had breaking changes this time around is more of a coincidence than a pattern.

Copy link
Member

@DJMcNab DJMcNab Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same release schedule and tagging for both is probably simpler, would be my claim.
Additionally, since they share a changelog, and a Fontique release requires a Parley release, mirroring that dependency probably doesn't really hurt things.

Especially since Fontique depends on Skrifa, any Parley release will realistically need a Fontique release anyway - Skrifa releases extremely often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants