Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StyleProperty::FontStack more ergonomic. #129

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

xorgy
Copy link
Member

@xorgy xorgy commented Oct 10, 2024

No description provided.

@xorgy xorgy requested a review from nicoburns October 10, 2024 14:16
Copy link
Contributor

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of suggestions but nothing major so also approving.

parley/src/style/font.rs Outdated Show resolved Hide resolved
examples/tiny_skia_render/src/main.rs Outdated Show resolved Hide resolved
@xorgy xorgy changed the title Add some convenience Into implementations for fonts and font stacks. Add some convenience From impls for FontFamily, FontStack, and StyleProperty. Oct 10, 2024
@xorgy xorgy force-pushed the font-intos branch 4 times, most recently from 7c25e30 to 1c3a093 Compare October 10, 2024 15:30
- Style builders now accept Into<StyleProperty<'a, B>>
- StyleProperty can be From GenericFamily, &'a str, or &'a [FontFamily<'a>]
@xorgy xorgy changed the title Add some convenience From impls for FontFamily, FontStack, and StyleProperty. Make StyleProperty::FontStack more ergonomic. Oct 10, 2024
@xorgy xorgy added this pull request to the merge queue Oct 10, 2024
Merged via the queue into linebender:main with commit 17f4e9f Oct 10, 2024
20 checks passed
@xorgy xorgy deleted the font-intos branch October 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants