Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoWify style types #128

Merged
merged 2 commits into from
Oct 9, 2024
Merged

CoWify style types #128

merged 2 commits into from
Oct 9, 2024

Conversation

nicoburns
Copy link
Contributor

This:

  • Converts parley style types to use std::borrow::Cow instead of references
  • Removes the lifetime parameter from PlainEditor and PlainEditorOp by making them using StyleProperty<'static>

This isn't ideal from an API point of view, but does at least allow PlainEditor to be stored within a struct.

It would be an option to leave the lifetime parameter in PlainEditor and make uses who want to store it in a struct specify PlainEditor<'static> themselves. I have not done so because I don't think there's much use for the borrowed editor outside of toy examples.

@nicoburns nicoburns added this pull request to the merge queue Oct 9, 2024
Merged via the queue into linebender:main with commit d4dcf36 Oct 9, 2024
20 checks passed
@nicoburns nicoburns deleted the cowify-style branch October 9, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants