Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
std::borrow::Cow
instead of referencesPlainEditor
andPlainEditorOp
by making them usingStyleProperty<'static>
This isn't ideal from an API point of view, but does at least allow
PlainEditor
to be stored within a struct.It would be an option to leave the lifetime parameter in
PlainEditor
and make uses who want to store it in a struct specifyPlainEditor<'static>
themselves. I have not done so because I don't think there's much use for the borrowed editor outside of toy examples.