Correctly calculate incenter in Triangle::inscribed_circle
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method erroneously calculated the circumcenter instead. This also changes the triangle tests to allow specifying a relative epsilon in the approximately-equal asserts, making them a bit more useful for testing values differing in orders of magnitude.
tomcur
added a commit
to tomcur/kurbo
that referenced
this pull request
Oct 8, 2024
(On top of PR linebender#387, as I'm removing a method here that is still used until that PR is merged. I'll keep this in draft until then.) This is based on the simplified form for Cartesian coordinates in https://en.wikipedia.org/w/index.php?title=Circumcircle&oldid=1247179617#Cartesian_coordinates_2 Also adds a test to check the circle radius' sign is equal to the sign of the triangle's area.
raphlinus
approved these changes
Oct 30, 2024
tomcur
added a commit
to tomcur/kurbo
that referenced
this pull request
Oct 31, 2024
(On top of PR linebender#387, as I'm removing a method here that is still used until that PR is merged. I'll keep this in draft until then.) This is based on the simplified form for Cartesian coordinates in https://en.wikipedia.org/w/index.php?title=Circumcircle&oldid=1247179617#Cartesian_coordinates_2 Also adds a test to check the circle radius' sign is equal to the sign of the triangle's area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method erroneously calculated the circumcenter instead.
Tagging along on this PR are some changes to the triangle tests that I used to track down some issues. If desired I can bump these to a separate PR. The asserts testing approximate equality now take a relative epsilon, making them a bit more useful for testing values differing in orders of magnitude. I've also recalculated some of the test values to specify them at 17 significant digits (absolute limit of
f64), and made the equality bounds tighter.