Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add control_box method to BezPath #306

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Add control_box method to BezPath #306

merged 2 commits into from
Oct 3, 2023

Conversation

dfrg
Copy link
Contributor

@dfrg dfrg commented Oct 3, 2023

This adds a method to BezPath that computes a conservative bounding box only taking control points into account.

@dfrg
Add control_box method to BezPath
0666868 
This adds a method to `BezPath` that computes a conservative bounding box only taking control points into account.
@dfrg
rustfmt
3b37196
raphlinus
raphlinus approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd slightly prefer returning Option<Rect>, but Chad points out that this is more consistent with the existing bounding_box method.

@dfrg dfrg merged commit ad67725 into linebender:main Oct 3, 2023
14 checks passed
@dfrg dfrg deleted the control-box branch October 3, 2023 18:12
anthrotype added a commit to googlefonts/fontations that referenced this pull request Oct 4, 2023
@anthrotype
use latest kurbo's BezPath::control_box instead of ControlBoundsPen
615d7f3 
because now we can: linebender/kurbo#306
@anthrotype anthrotype mentioned this pull request Oct 4, 2023
Merged
anthrotype added a commit to googlefonts/fontations that referenced this pull request Oct 4, 2023
@anthrotype
use latest kurbo's BezPath::control_box instead of ControlBoundsPen
0be7e7c 
because now we can: linebender/kurbo#306
dfrg pushed a commit to googlefonts/fontations that referenced this pull request Oct 4, 2023
@anthrotype @dfrg
use latest kurbo's BezPath::control_box instead of ControlBoundsPen
b76d678 
because now we can: linebender/kurbo#306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfrg @raphlinus