Skip to content

Depenendencies updated #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Depenendencies updated #20

merged 3 commits into from
Feb 12, 2025

Conversation

spirali
Copy link
Collaborator

@spirali spirali commented Feb 8, 2025

No description provided.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating maud is good, but we will need to follow-up to update the rest of the dependency specifications.

imagesize = "0.13"
serde = { version = "1.0.217", features = ["derive"] }
serde = { version = "1", features = ["derive"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our policy in Linebender is to generally give "precise" bounds on dependencies. See linebender/rfcs#5

So this should still be 1.0.217, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returned "1.0.217"

tokio = "1.43"
axum = "0.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should add formatting using Taplo here (see linebender/vello#809)

This again shouldn't happen in this PR

@spirali spirali mentioned this pull request Feb 12, 2025
@spirali spirali added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 8f3f5e5 Feb 12, 2025
15 checks passed
@spirali spirali deleted the update branch February 12, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants