Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Pointer Events #127

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

waywardmonkeys
Copy link
Contributor

This is a draft as I think it is something people may want to comment on.

It is currently only on Windows, but I'll probably push a commit with Mac support soon (within the next day or three).

It doesn't do any extra features yet like multiple pointers. That requires using the raw input API on Windows, I think. (But that can happen separately.)

Once #126 lands (or is rejected), I'll update this via rebase to remove the extra stuff from here.

There's interesting questions once multiple pointers are supported, like how the capturing code should handle that.

I don't have any fancy Windows input devices.

@jneem
Copy link
Collaborator

jneem commented Jul 31, 2023

This looks fine to me, with or without mac support. Getting all the backends ported to the pointer API (even without actual multi-pointer support) will let us get rid of the old mouse API

@waywardmonkeys
Copy link
Contributor Author

This looks fine to me, with or without mac support. Getting all the backends ported to the pointer API (even without actual multi-pointer support) will let us get rid of the old mouse API

Yes, the equivalent version of this for Mac should be easy to knock out.

And yeah, I'd chase this with a PR to remove the old mouse API. Need to do some outreach to Lapce to get them to switch over as well and someone will have to tackle Xilem. (I've got a PR open there to get Xilem at least on the current version of Glazier: linebender/xilem#118)

@waywardmonkeys waywardmonkeys force-pushed the more-pointer-events branch 2 times, most recently from 03aed59 to df0dc2b Compare August 2, 2023 16:05
@waywardmonkeys waywardmonkeys marked this pull request as ready for review August 2, 2023 16:06
This is a basic conversion and doesn't handle things like
multiple pointers or other input devices yet.
@waywardmonkeys
Copy link
Contributor Author

@jneem I've flagged this as ready for review / landing. It handles both macOS and Windows for the basic conversion.

Web backend doesn't compile at all, so I'll handle it separately.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Aug 2, 2023
Merged via the queue into linebender:main with commit b7e9e1f Aug 2, 2023
10 checks passed
@waywardmonkeys waywardmonkeys deleted the more-pointer-events branch August 2, 2023 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants