feat: allow any defined response value #214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response validator as written fails for valid JSON (e.g.
null
,"foo"
,true
, etc.). If the validator is going to enforce valid JSON, it should allow all JSON values, not just some. Furthermore, in my opinion this package shouldn't be concerned with validating a user-provided response, perhaps other than asserting that it is defined. Some APIs return invalid JSON - this package should support mocking those, too.My changes here relax the
response
validation to merely asserting that it is notundefined
. One could argue thatundefined
should be allowed too, but in this PR I'm only interested in permitting any defined value.This PR would supersede #201 and close #200