Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Service View Page with Tabs(part1)-Service button group #546

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

bai1024
Copy link
Contributor

@bai1024 bai1024 commented Sep 26, 2024

Split this PR into two parts.
This one is the part1, only focus on service-button-group changes
Before:
image

After:
image

@bai1024 bai1024 requested review from kfdm and a team as code owners September 26, 2024 06:31
@bai1024 bai1024 changed the title Service button group Organize Service View Page with Tabs(part1)-Service button group Sep 26, 2024
@bai1024 bai1024 force-pushed the service-button-group branch from 848f807 to e06183d Compare October 7, 2024 05:37
@vincent-olivert-riera
Copy link
Contributor

vincent-olivert-riera commented Oct 10, 2024

@vincent-olivert-riera force-pushed the service-button-group branch from e06183d to 8603be3

I rebased your branch on master before merging it.

@vincent-olivert-riera vincent-olivert-riera merged commit 599eb7b into line:master Oct 10, 2024
5 checks passed
@vincent-olivert-riera
Copy link
Contributor

@bai1024 , approved and merged. Good job, and thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants