Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.66 #545

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Release 0.66 #545

merged 2 commits into from
Sep 26, 2024

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Sep 25, 2024

Cutting a final release from me.

@kfdm kfdm requested a review from a team as a code owner September 25, 2024 03:49
@vincent-olivert-riera
Copy link
Contributor

@kfdm , which commit are you going to chose for the tag?
I see that the changes for the silence list modal are not included in the changelog.

@kfdm
Copy link
Collaborator Author

kfdm commented Sep 25, 2024

@kfdm , which commit are you going to chose for the tag? I see that the changes for the silence list modal are not included in the changelog.

I think the commit was included, but the commit messages were not formatted correctly so it was missed when creating the changelog.

It's not a major change, so I'm not going to spend time trying to redo the changelog.

@vincent-olivert-riera
Copy link
Contributor

@kfdm , which commit are you going to chose for the tag? I see that the changes for the silence list modal are not included in the changelog.

I think the commit was included, but the commit messages were not formatted correctly so it was missed when creating the changelog.

It's not a major change, so I'm not going to spend time trying to redo the changelog.

I see. No problem at all 👍

Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfdm
Copy link
Collaborator Author

kfdm commented Sep 25, 2024

Not sure why the license/cla is stuck but this has happened in the past . . .

@vincent-olivert-riera
Copy link
Contributor

Not sure why the license/cla is stuck but this has happened in the past . . .

Uhm..., just in case, could you check https://cla-assistant.io/line/promgen again?

@kfdm
Copy link
Collaborator Author

kfdm commented Sep 26, 2024

Confirmed that link and nothing has changed. I did that years ago when it was first enabled ^^;

@vincent-olivert-riera vincent-olivert-riera merged commit fd6aae9 into line:master Sep 26, 2024
4 checks passed
@vincent-olivert-riera
Copy link
Contributor

Confirmed that link and nothing has changed

I will try to pass that information to the relevant people to see what is going on.

I have merged the PR for you.

@kfdm kfdm deleted the release-0-66 branch September 26, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants