Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Move proxy_error to util.proxy_error for reuse #527

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jul 3, 2024

We can move our proxy_error wrapper so that it can be reused in our PromqlQuery View to keep things consistent.

We can move our proxy_error wrapper so that it can be reused in our
PromqlQuery View to keep things consistent.
@kfdm kfdm requested a review from a team as a code owner July 3, 2024 07:57
Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kfdm kfdm merged commit 0c787f2 into line:master Jul 3, 2024
5 checks passed
@kfdm kfdm deleted the util-proxy-error branch July 3, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants