Fix github pages deploy #444
Merged
+27
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deploy with action artifacts, not from gh-pages branch - check ref with master, not wiht main
|
|
kfdm
reviewed
Oct 31, 2023
Co-authored-by: Paul Traylor <[email protected]>
kfdm
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Looks good to me!
Thank you very much for catching this. I think we (as a team) never quite decided on github pages or readthedocs for the documentation and unfortunately it looks like both methods broke over time 😅
With this PR, I think we have a much better setup and we can probably use the github pages version for our docs. Thank you for your contribution 🙇
kfdm
added a commit
to kfdm/promgen
that referenced
this pull request
Nov 2, 2023
In line#444 the github actions was fixed to publish to gh-pages properly. Since our readthedocs build is current broken anyways, it is probably better to promote the github pages version as canotical since that will also result in less of a maintenance burden for other contributors.
kfdm
added a commit
to kfdm/promgen
that referenced
this pull request
Nov 2, 2023
In line#444 the github actions was fixed to publish to gh-pages properly. Since our readthedocs build is currently broken anyways, it is probably better to promote the github pages version as canonical since that will also result in less of a maintenance burden for other contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #443
ex) https://github.com/sh-cho/promgen/actions/runs/6706997395
Only deploy on push master branch (using github actions context)
gh-pagesbranch can be removed after this PR is merged