Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup promgen bootstrap and some settings #270

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Apr 3, 2020

This should help with part of the issues in #266 regarding the django sites.Site object and how it's used for building requests

@codecov-io
Copy link

Codecov Report

Merging #270 into master will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   47.22%   47.31%   +0.08%     
==========================================
  Files          57       57              
  Lines        2651     2646       -5     
==========================================
  Hits         1252     1252              
+ Misses       1399     1394       -5     
Impacted Files Coverage Δ
promgen/settings.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997e468...ca677b3. Read the comment docs.

@kfdm kfdm changed the title Bootstrap site Cleanup promgen bootstrap and some settings Apr 7, 2020
@kfdm kfdm requested a review from shokada April 7, 2020 01:58
@kfdm kfdm marked this pull request as ready for review April 7, 2020 01:58
@kfdm kfdm force-pushed the bootstrap-site branch from 02b209c to 0d03714 Compare April 7, 2020 01:58
@kfdm kfdm merged commit e0646a6 into line:master Apr 7, 2020
@kfdm kfdm deleted the bootstrap-site branch April 7, 2020 02:12
@kfdm kfdm mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants