Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use personal acesss token to trigger CI builds #871

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Aug 25, 2023

Motivation:

When a PR is created by a workflow with the deafult GITHUB_TOKEN which is given by GitHub Actions, CI builds aren't triggered. https://github.com/orgs/community/discussions/55906

Releated: #870

Modifications:

Result:

CI is correctly run when an Armeria version upgrade PR is made

Motivation:

When a PR is created by a workflow with the deafult GITHUB_TOKEN which
is given by GitHub Actions, CI builds aren't triggered.
https://github.com/orgs/community/discussions/55906

Releated: line#870

Modifications:

- Use PAT of our friendly bot @armerian

Result:

CI is correctly run when an Armeria version upgrade PR is made
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikhoon
Copy link
Contributor Author

ikhoon commented Aug 25, 2023

The new Armeria version has been uploaded. https://repo.maven.apache.org/maven2/com/linecorp/armeria/armeria-bom/1.25.2/

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (2b7d58a) 65.65% compared to head (aeabbd6) 65.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #871      +/-   ##
============================================
+ Coverage     65.65%   65.67%   +0.02%     
- Complexity     3346     3350       +4     
============================================
  Files           358      358              
  Lines         13893    13893              
  Branches       1496     1496              
============================================
+ Hits           9121     9124       +3     
+ Misses         3919     3916       -3     
  Partials        853      853              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@minwoox minwoox merged commit 49a71fd into line:main Dec 27, 2023
11 checks passed
@ikhoon ikhoon deleted the armerian-pat branch August 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants