Upgrade dependencies for 0.62.0 #867
Conversation
dependencies.toml
Outdated
| @@ -3,23 +3,23 @@ | |||
| # If its classes are exposed in Javadoc, update offline links as well. | |||
| # | |||
| [versions] | |||
| armeria = "1.24.3" | |||
| armeria = "1.25.0" | |||
There was a problem hiding this comment.
nit:
| armeria = "1.25.0" | |
| armeria = "1.25.1" |
| @@ -146,9 +147,10 @@ protected void doCloseAsync(CompletableFuture<?> future) { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return toStringHelper() | |||
| return toStringHelper(this) | |||
There was a problem hiding this comment.
Using this approach as opposed to using the toString(Consumer<StringBuilder>) API since using a StringBuilder required me to format things manually
There was a problem hiding this comment.
It sounds like we need toString(Map<String, Object> additionalProperties).
subrepo: subdir: "gradle/scripts" merged: "7edd0367" upstream: origin: "https://github.com/line/gradle-scripts.git" branch: "main" commit: "7edd0367" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
We may add the github-actions bot as a whitelist. Let's ask Seoyeon later when she comes back from vacation. |
| @@ -146,9 +147,10 @@ protected void doCloseAsync(CompletableFuture<?> future) { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return toStringHelper() | |||
| return toStringHelper(this) | |||
There was a problem hiding this comment.
It sounds like we need toString(Map<String, Object> additionalProperties).
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
============================================
- Coverage 65.58% 65.57% -0.02%
- Complexity 3347 3348 +1
============================================
Files 358 358
Lines 13910 13914 +4
Branches 1494 1497 +3
============================================
+ Hits 9123 9124 +1
- Misses 3936 3937 +1
- Partials 851 853 +2
☔ View full report in Codecov by Sentry. |
Note: I wasn't sure how CLA works for #865, so I just also included armeria upgrades in this PR.