Update cron-utils to 9.2.1 #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why we haven't upgrade cron-utils to the latest. There's no reason not to upgrade it. cron-utils: 5.0.5 -> 9.2.1
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
============================================
+ Coverage 65.50% 65.53% +0.02%
- Complexity 3328 3331 +3
============================================
Files 356 356
Lines 13962 13970 +8
Branches 1499 1500 +1
============================================
+ Hits 9146 9155 +9
+ Misses 3964 3960 -4
- Partials 852 855 +3
☔ View full report in Codecov by Sentry. |
ikhoon
approved these changes
Aug 23, 2023
| return next.get().plus(jitterMillis, ChronoUnit.MILLIS); | ||
| } | ||
| throw new IllegalArgumentException( | ||
| "no next execution time for " + CRON_DESCRIPTOR.describe(schedule) + ", lastExecutionTime: " + |
There was a problem hiding this comment.
nit: Should we log localRepo as well to inform the errors to users.
There was a problem hiding this comment.
I was also thinking about logging the information but it's logged here so I didn't include it. 😉
jrhee17
approved these changes
Aug 24, 2023
trustin
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we haven't upgrade cron-utils to the latest. There's no reason not to upgrade it.
cron-utils: 5.0.5 -> 9.2.1