Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK 19 build in CI #861

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add JDK 19 build in CI #861

merged 1 commit into from
Jul 26, 2023

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented Jul 26, 2023

  • Update Proguard: 7.2.2 -> 7.3.1
  • Use JDK 17 for testing in Mac OS and Windows builds
  • Use actions/checkout@v3, actions/setup-java@v3, and codecov/codecov-action@v3

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.78% 🎉

Comparison is base (4fd5ef8) 64.79% compared to head (0d4bd1f) 65.57%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #861      +/-   ##
============================================
+ Coverage     64.79%   65.57%   +0.78%     
- Complexity     3277     3330      +53     
============================================
  Files           356      356              
  Lines         13962    13962              
  Branches       1499     1499              
============================================
+ Hits           9046     9155     +109     
+ Misses         4062     3954     -108     
+ Partials        854      853       -1     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy as long as the build passes 👍 🙇 🚀

Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikhoon ikhoon merged commit 07a1fa6 into line:main Jul 26, 2023
9 of 10 checks passed
@minwoox minwoox deleted the add_JDK19_build branch July 26, 2023 10:17
@minwoox minwoox added this to the 0.61.6 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants