Upgrade Jinja support to work with Django 5 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: make it work for django5.0 * Update CHANGELOG --------- Co-authored-by: peko <[email protected]>
* GitHub Actions: Add Python 3.12 to the testing As discussed at torchbox#236 (review) * tox.ini: Add py312 * Stop testing Django v4.1
…rary into jinja * 'main' of https://github.com/torchbox/django-pattern-library: Add Python 3.12 to the test matrix, drop Django 4.1 (torchbox#242) Updates for version 1.2.0 Improve handling of non-string values for 'override_tag's 'default_html' argument (torchbox#224) fix: make it work for django5.0 (updated) (torchbox#241) Upgrade GitHub Actions versions (torchbox#237) Fix typos discovered by codespell (torchbox#238)
maribedran
reviewed
Feb 26, 2024
There was a problem hiding this comment.
@CuriousLearner everything looks good. Can you update the poetry lock file to fix the CI?
|
Once CI is fixed let's merge this please. |
CuriousLearner
force-pushed
the
upgrade-jinja-django-5
branch
from
31287b4
to
6a73acb
Compare
CuriousLearner
force-pushed
the
upgrade-jinja-django-5
branch
from
5d2bc3b
to
10b90af
Compare
|
@CuriousLearner I don't think the build site CI action concerns us, right? Everything looks good to me. |
|
I think so, but wasn't sure if it was working before 😅 So, we're good to merge then @mtrythall |
|
@CuriousLearner our branch was based on this outdated PR: torchbox#206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.