Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new node type that wraps pzflow and create an introductory notebook #181

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jeremykubica
Copy link
Contributor

Create a new node type that allows us to consistently sample from pzflow. This node will determine its parameters based on the information the flow computes, allowing them to be used for other parameter setters.

The demo notebook includes the basics of setting up nodes and sampling. It uses the new pzflow node as an example.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Oct 30, 2024

Before [9ea64af] After [1a7bf09] Ratio Benchmark (Parameter)
1.33±0.01s 1.38±0.01s 1.04 benchmarks.TimeSuite.time_make_x1_from_hostmass
4.31±0.1ms 4.44±1ms 1.03 benchmarks.TimeSuite.time_chained_evaluate
700±700μs 719±20μs 1.03 benchmarks.TimeSuite.time_fnu_to_flam
4.68±0.1ms 4.71±0.1ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_passbands
8.90±0.03ms 8.95±0.08ms 1.01 benchmarks.TimeSuite.time_load_passbands
122±0.8μs 122±2μs 1 benchmarks.TimeSuite.time_sample_x0_from_distmod
8.55±0.7ms 8.47±0.3ms 0.99 benchmarks.TimeSuite.time_evaluate_salt3_model
16.1±0.1μs 15.9±0.2μs 0.99 benchmarks.TimeSuite.time_sample_x1_from_hostmass
27.7±0.2μs 27.2±0.3μs 0.98 benchmarks.TimeSuite.time_make_new_salt3_model
1.46±0.08ms 1.38±0.06ms 0.94 benchmarks.TimeSuite.time_apply_passbands

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant