Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SN Ia efficiency functions #176

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add SN Ia efficiency functions #176

merged 3 commits into from
Nov 5, 2024

Conversation

mi-dai
Copy link
Contributor

@mi-dai mi-dai commented Oct 25, 2024

Add functions to calculate photometric detection efficiency and spectroscopic follow-up efficiency. Actual implementation in the pipeline will be next step.

Copy link

github-actions bot commented Oct 25, 2024

Before [88bd226] After [d59a0f1] Ratio Benchmark (Parameter)
4.30±1ms 4.41±0.2ms 1.03 benchmarks.TimeSuite.time_chained_evaluate
9.46±1ms 9.78±1ms 1.03 benchmarks.TimeSuite.time_evaluate_salt3_model
5.20±0.4ms 5.28±0.2ms 1.02 benchmarks.TimeSuite.time_evaluate_salt3_passbands
1.41±0.07ms 1.41±0.09ms 1 benchmarks.TimeSuite.time_apply_passbands
15.6±0.2μs 15.5±0.5μs 1 benchmarks.TimeSuite.time_sample_x1_from_hostmass
1.99±1ms 1.97±1ms 0.99 benchmarks.TimeSuite.time_fnu_to_flam
8.96±0.08ms 8.87±0.05ms 0.99 benchmarks.TimeSuite.time_load_passbands
27.8±0.3μs 27.3±0.1μs 0.99 benchmarks.TimeSuite.time_make_new_salt3_model
1.35±0.01s 1.33±0.01s 0.98 benchmarks.TimeSuite.time_make_x1_from_hostmass
122±3μs 119±1μs 0.98 benchmarks.TimeSuite.time_sample_x0_from_distmod

Click here to view all benchmarks.

Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just want to check that test_obs_utils.py is intentionally left blank, however--is this a placeholder?

@mi-dai
Copy link
Contributor Author

mi-dai commented Oct 25, 2024

Whoops, I meant to write tests but just somehow forgot about it! Will do it in another PR. Thanks for catching it!

@mi-dai
Copy link
Contributor Author

mi-dai commented Oct 28, 2024

@OliviaLynn I added tests here. Could you take another look?

@mi-dai mi-dai merged commit fbb4386 into main Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants