Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for from_flat #139

Merged
merged 2 commits into from
Aug 20, 2024
Merged

add fix for from_flat #139

merged 2 commits into from
Aug 20, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Aug 19, 2024

Resolves #138 .

@dougbrn dougbrn marked this pull request as ready for review August 19, 2024 21:58
Copy link

github-actions bot commented Aug 19, 2024

Before [6e2f433] <v0.2.0> After [a035380] Ratio Benchmark (Parameter)
1.11±0.02ms 1.13±0.01ms 1.02 benchmarks.NestedFrameReduce.time_run
277M 282M 1.02 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
86.9M 87.1M 1 benchmarks.NestedFrameAddNested.peakmem_run
10.0±0.2ms 10.0±0.1ms 1 benchmarks.NestedFrameAddNested.time_run
92M 92.1M 1 benchmarks.NestedFrameQuery.peakmem_run
6.72±0.09ms 6.71±0.1ms 1 benchmarks.NestedFrameQuery.time_run
90.5M 90.6M 1 benchmarks.NestedFrameReduce.peakmem_run
263M 261M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
32.4±1ms 31.5±0.9ms 0.97 benchmarks.AssignSingleDfToNestedSeries.time_run
63.8±3ms 60.9±3ms 0.95 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from wilsonbb August 19, 2024 22:03
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (6e2f433) to head (0556592).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          14       14           
  Lines         932      933    +1     
=======================================
+ Hits          927      928    +1     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn merged commit 0d8c2f3 into main Aug 20, 2024
11 checks passed
@dougbrn dougbrn deleted the fix_from_flat branch August 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedFrame.from_flat treats all non-base columns as nested columns
2 participants