-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frame-level get and set interface #135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 99.44% 99.45% +0.01%
==========================================
Files 14 14
Lines 897 917 +20
==========================================
+ Hits 892 912 +20
Misses 5 5 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Description
Resolves #99
Solution Description
This PR enables a pandas-like get and set interface with nested columns. The implementation is just augmenting
__getitem__
and__setitem__
to understand the hierarchical column naming scheme and handle it appropriately. We have held off on this because nested-pandas is not optimized for it, as this implementation involves a full rebuild of a nested column when doing things like adding or modifying a column. I added a tutorial with a note on this performance issue, but it's probably better that this is here but slow instead of sitting in the backlog :)Code Quality