Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Docstring: Update with note on using dictionary outputs #107

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jun 10, 2024

resolves #106. Partially addresses lincc-frameworks/nested-dask#27 as well.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (d9c2e6e) to head (93571af).
Report is 50 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          15       15           
  Lines         894      894           
=======================================
  Hits          883      883           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 10, 2024

Before [d9c2e6e] After [167e08b] Ratio Benchmark (Parameter)
31.3±2ms 32.5±2ms 1.04 benchmarks.AssignSingleDfToNestedSeries.time_run
255M 260M 1.02 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
6.34±0.07ms 6.49±0.1ms 1.02 benchmarks.NestedFrameQuery.time_run
87.6M 88.3M 1.01 benchmarks.NestedFrameQuery.peakmem_run
84M 84M 1 benchmarks.NestedFrameAddNested.peakmem_run
9.38±0.1ms 9.35±0.2ms 1 benchmarks.NestedFrameAddNested.time_run
87.2M 87.2M 1 benchmarks.NestedFrameReduce.peakmem_run
279M 279M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
1.05±0.01ms 1.03±0.01ms 0.98 benchmarks.NestedFrameReduce.time_run
63.5±1ms 60.9±4ms 0.96 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

@dougbrn dougbrn marked this pull request as ready for review June 10, 2024 18:57
@dougbrn dougbrn requested a review from hombit June 10, 2024 18:57
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you

@dougbrn dougbrn merged commit 5cf1fa5 into main Jun 10, 2024
11 checks passed
@dougbrn dougbrn deleted the reduce_func_note branch June 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reduce function recommendation
2 participants