Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow dropna on nested columns as base columns #105

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jun 6, 2024

Change Description

Resolves #104

  • My PR includes a link to the issue that I am addressing

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (0bb042a) to head (de46a67).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files          15       15              
  Lines         895      894       -1     
==========================================
- Hits          884      883       -1     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review June 6, 2024 20:28
Copy link

github-actions bot commented Jun 6, 2024

Before [6152580] After [ccbbf5b] Ratio Benchmark (Parameter)
31.5±2ms 32.8±4ms 1.04 benchmarks.AssignSingleDfToNestedSeries.time_run
259M 259M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
84M 84M 1 benchmarks.NestedFrameAddNested.peakmem_run
8.74±0.1ms 8.77±0.07ms 1 benchmarks.NestedFrameAddNested.time_run
88.2M 88.1M 1 benchmarks.NestedFrameQuery.peakmem_run
87.3M 87.2M 1 benchmarks.NestedFrameReduce.peakmem_run
6.27±0.09ms 6.21±0.08ms 0.99 benchmarks.NestedFrameQuery.time_run
278M 274M 0.99 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
58.6±3ms 58.0±2ms 0.99 benchmarks.ReassignHalfOfNestedSeries.time_run
1.05±0ms 1.03±0ms 0.98 benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from hombit June 6, 2024 20:29
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dougbrn dougbrn merged commit d9c2e6e into main Jun 6, 2024
11 checks passed
@dougbrn dougbrn deleted the dropna_layer_as_base branch June 6, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Dropna to work on nested columns as base columns
2 participants