Draft: Initial buildout of lincbrain CLI/Python Client from dandi-cli #2
Conversation
| @@ -417,7 +417,7 @@ def __init__( | |||
| :param str token: User API Key. Note that different instance APIs have | |||
| different keys. | |||
| """ | |||
| check_dandi_version() | |||
There was a problem hiding this comment.
check_dandi_version() (and versioneer by extension) still need to be set up correctly -- thus references are commented out for now.
| if our_version < minversion: | ||
| raise CliVersionTooOldError(our_version, minversion, bad_versions) | ||
| if our_version in bad_versions: | ||
| raise BadCliVersionError(our_version, minversion, bad_versions) |
There was a problem hiding this comment.
Similar to https://github.com/lincbrain/linc-cli/pull/2/files#r1406776675 -- versioneer needs to be refined
| # try: | ||
| # import versioneer | ||
| # version_config = versioneer.get_version() | ||
| # cmdclass = versioneer.get_cmdclass() | ||
| # except ImportError: | ||
| # print("WARNING: failed to import versioneer, falling back to no version for now") | ||
| # version_config = "0.4.0" # Fallback version | ||
| # cmdclass = {} |
There was a problem hiding this comment.
Similar to https://github.com/lincbrain/linc-cli/pull/2/files#r1406776675 -- versioneer needs to be refined
setup.py
Outdated
|
|
||
| if __name__ == "__main__": | ||
| setup( | ||
| name="lincbrain", | ||
| version="0.1.0", | ||
| cmdclass=cmdclass, | ||
| version="0.9.0", |
There was a problem hiding this comment.
This is the value that is bumped to create a new semantic version in PyPI for now during the build and distribute phases
|
Hi @aaronkanzer, let's change the term from
|
|
Should we change |
aaronkanzer
changed the title
lincbrain/cli/command.py
Outdated
There was a problem hiding this comment.
Please update line 100 to the following:
logdir = platformdirs.user_log_dir("lincbrain-cli", "lincbrain")
This PR/branch is being used to clone/transform the
dandi-cliinto thelincbrainCLI tool.A couple things:
versioneeris still problematic forlincbrain, therefore, references are commented out.The publishing process includes:
Bump the value here: Draft: Initial buildout of lincbrain CLI/Python Client from dandi-cli #2 (comment)
Run
python setup.py sdist bdist_wheellocally -- this will populate a new build value in your localdist/folderRun
twine upload dist/lincbrain-<new-semantic-version>*You'll be prompted for a username and password: for username, use
__token__, for password, use a PyPI token issued to you (ask @aaronkanzer for one if you don't have it)This workflow will change, but should be sufficient for now