Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tw 1846 update style of image picker #2167

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

KhaledNjim
Copy link
Contributor

@KhaledNjim KhaledNjim commented Dec 2, 2024

Ticket

Need Merge

Impact description

Design update for image picker

Test recommendations

Recommendations for how to test this, or anything else you are worried about?

Pre-merge

Does anything else need to be done before merging?

Resolved

Attach screenshots or videos demonstrating the changes

  • Web:

  • Android:
    image
    image

  • IOS:

Copy link

github-actions bot commented Dec 2, 2024

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2167

@nqhhdev
Copy link
Member

nqhhdev commented Dec 4, 2024

Screenshot 2024-12-04 at 10 01 48

I think wrong color for background.

  • Background body: M3/sys light/BG + Surface/background - n99
  • Background button: M3/sys light/BG + Surface/surface

@hoangdat
Copy link
Member

hoangdat commented Dec 9, 2024

merged system-design, please update

@KhaledNjim
Copy link
Contributor Author

merged system-design, please update

Updated

@KhaledNjim
Copy link
Contributor Author

Screenshot 2024-12-04 at 10 01 48 I think wrong color for background.
  • Background button: M3/sys light/BG + Surface/background - n99
  • Background body: M3/sys light/BG + Surface/surface

Updated

image

@hoangdat
Copy link
Member

Screenshot 2024-12-04 at 10 01 48 I think wrong color for background.
  • Background button: M3/sys light/BG + Surface/background - n99
  • Background body: M3/sys light/BG + Surface/surface

Updated

I didn't see your change for this.

@KhaledNjim
Copy link
Contributor Author

Screenshot 2024-12-04 at 10 01 48 I think wrong color for background.
  • Background button: M3/sys light/BG + Surface/background - n99
  • Background body: M3/sys light/BG + Surface/surface

Updated

I didn't see your change for this.

i updated in commit e04c6ab

@hoangdat hoangdat merged commit 13d7c2f into main Dec 12, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1846_update_style_of_image_picker branch December 12, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants