New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tw 2088 systemize app bar #2116

Merged

hoangdat merged 5 commits into main from TW-2088_Systemize_appBar

Nov 20, 2024

Contributor

KhaledNjim commented Oct 29, 2024 •

edited

Loading

Ticket

Systemlizing AppBar style for Twake Chat app and apply it for mobile and web #2088

Solution

Added TwakeAppBar component and used in similar app bars

Test recommendations

Recommendations for how to test this, or anything else you are worried about?

Resolved

Web:

Android:
IOS:

KhaledNjim requested review from sherlockvn, hoangdat, dab246, nqhhdev, hieutbui and tddang-linagora as code owners

October 29, 2024 23:46

KhaledNjim temporarily deployed to PR-2116

October 29, 2024 23:46

— with

GitHub Actions Inactive

github-actions bot commented Oct 29, 2024

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2116

KhaledNjim force-pushed the TW-2088_Systemize_appBar branch from b117745 to 5e904ee Compare

October 30, 2024 22:21

KhaledNjim temporarily deployed to PR-2116

October 30, 2024 22:21

— with

GitHub Actions Inactive

hoangdat reviewed

View reviewed changes

lib/pages/chat_details/chat_details_view.dart Show resolved Hide resolved

hoangdat force-pushed the TW-2088_Systemize_appBar branch from 5e904ee to 577bed5 Compare

November 11, 2024 10:43

hoangdat temporarily deployed to PR-2116

November 11, 2024 10:44

— with

GitHub Actions Inactive

hoangdat reviewed

View reviewed changes

lib/pages/chat_details/chat_details_view.dart Outdated Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/widgets/app_bars/twake_app_bar.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/widgets/app_bars/twake_app_bar_style.dart Outdated Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/widgets/app_bars/twake_app_bar_style.dart Outdated Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/pages/contacts_tab/contacts_appbar_style.dart Outdated Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/pages/settings_dashboard/settings/settings_view.dart Show resolved Hide resolved

KhaledNjim self-assigned this

KhaledNjim temporarily deployed to PR-2116

November 17, 2024 21:41

— with

GitHub Actions Inactive

KhaledNjim added 5 commits

November 19, 2024 10:44


          TW-2088 added TwakeAppBar component

9fa383a


          TW-2088 use TwakeAppBar in chatList settings and contacts

7a85ef6


          TW-2088 used TwakeAppBar in settings pages

9293b10


          TW-2088 used TwakeAppBar in Group information

0501d84


          TW-2088 change chevron icon in appbars

228dfbd

KhaledNjim force-pushed the TW-2088_Systemize_appBar branch from 8636040 to 228dfbd Compare

November 19, 2024 09:54

KhaledNjim deployed to PR-2116

November 19, 2024 09:54

— with

GitHub Actions View deployment

hoangdat approved these changes

View reviewed changes

hoangdat merged commit 0753032 into main

7 checks passed

hoangdat deleted the TW-2088_Systemize_appBar branch

November 20, 2024 02:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hoangdat hoangdat approved these changes

sherlockvn Awaiting requested review from sherlockvn

dab246 Awaiting requested review from dab246 dab246 is a code owner

nqhhdev Awaiting requested review from nqhhdev nqhhdev is a code owner

hieutbui Awaiting requested review from hieutbui

tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Labels

None yet