handle parsing exception for OIDCHttpClient::checkOIDCIsAvailable()
#3459
Conversation
… relevance, the filter isn't applied
…t them by relevance
…r out invalid suggestions
…ed in with the same account
…ed in with the other account
Signed-off-by: Emmanuel Ferdman <[email protected]>
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3459. |
|
Please record a little video accessing a fastmail account after this change, if possible. |
|
From the same discussion:
There's no point showing our own log in form. We need to add OAuth support in order for FastMail to work on Twake Mail. |
| } on FormatException catch (exception) { | ||
| log('checkOIDCIsAvailable(): error while parsing server response (JSON expected): ${exception.message}'); | ||
| rethrow; | ||
| } on DioError catch (exception) { |
There was a problem hiding this comment.
Please be more specific about the error. FormatException is too general an error.
There was a problem hiding this comment.
done, i created a InvalidOIDCResponseException
correct, issue 3455 has already been open on the topic
thus with the current work we still cannot access a fastmail account, but the parsing exception is handled and the app falls back to the basic auth form instead of throwing an error: fix-parsing-exception.mp4 |
here is a fix for a bug pointed out by this user experience review.
https://api.fastmail.com/jmap/session, the actual error is a401 Unauthorizedand this case was handeled in this pull request ;https://api.fastmail.com, another error occured because the server answers with HTML instead of JSON, eg,FormatException. the correct behaviour, which i fix with the current PR, is to ignore webfinger and fall back to the classic credential form.