-
Notifications
You must be signed in to change notification settings - Fork 88
handle parsing exception for OIDCHttpClient::checkOIDCIsAvailable()
#3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3459. |
Please record a little video accessing a fastmail account after this change, if possible. |
From the same discussion:
There's no point showing our own log in form. We need to add OAuth support in order for FastMail to work on Twake Mail. |
correct, issue 3455 has already been open on the topic
thus with the current work we still cannot access a fastmail account, but the parsing exception is handled and the app falls back to the basic auth form instead of throwing an error: fix-parsing-exception.mp4 |
Is it ok if I force push here to clean the 39 commits that don't belong to this PR ? |
first, please use git rebase to only pick your modification for this issue, then force push. |
d380782
to
f2a256d
Compare
@hoangdat @tddang-linagora @dab246 I rebased on latest master and checked that the demo is still the same, it is all good. Tell me if you have any last comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
here is a fix for a bug pointed out by this user experience review.
https://api.fastmail.com/jmap/session
, the actual error is a401 Unauthorized
and this case was handeled in this pull request ;https://api.fastmail.com
, another error occured because the server answers with HTML instead of JSON, eg,FormatException
. the correct behaviour, which i fix with the current PR, is to ignore webfinger and fall back to the classic credential form.