contact support setting option #3452

florentos17 · 2025-01-24T16:29:08Z

tackling this issue

disclaimer: i could not test it because i could not find a server that advertizes the contactSupport capability

github-actions · 2025-01-24T16:39:35Z

This PR has been deployed to https://linagora.github.io/tmail-flutter/3452.

chibenwa · 2025-01-24T20:26:53Z

disclaimer: i could not test it because i could not find a server that advertizes the contactSupport capability

Sent privatly

chibenwa · 2025-01-28T13:44:18Z

Can you please record a little demo video of this fix?

florentos17 · 2025-01-28T15:47:54Z

here is a demo on mobile:
Screencast from 28-01-2025 16:09:56.webm

for some reason when i launch the web version connected to https://jmap.govmu.org/, the page does not update with the new option, or any other change at all... but it does update when i connect to https://jmap.lin-saas.dev, so here is a screenshot:

florentos17 · 2025-01-31T13:11:55Z

the force push was to clean the commit history ; i also added some unit tests

some comments about the second commit:

currently, tmail-backend advertizes the ContactSupport capability as a DefaultCapability, hence the new getContactSupportCapability which can now handle both.
moreover, sometimes the advertized capability is actually empty (no email address and no link), so it is advertized as supported, but is not really supported... the new getContactSupportCapability also handles this case.

but maybe the correct way to handle this would be to change the advertizing done on tmail-backend side ?

lib/features/home/domain/extensions/session_extensions.dart

lib/features/manage_account/presentation/menu/manage_account_menu_view.dart

tddang-linagora · 2025-02-03T07:42:34Z

Nothing happens when click "Contact support" on web

Screen.Recording.2025-02-03.at.14.38.42.mov

dab246 · 2025-02-03T09:44:55Z

the force push was to clean the commit history ; i also added some unit tests

some comments about the second commit:

currently, tmail-backend advertizes the ContactSupport capability as a DefaultCapability, hence the new getContactSupportCapability which can now handle both.

moreover, sometimes the advertized capability is actually empty (no email address and no link), so it is advertized as supported, but is not really supported... the new getContactSupportCapability also handles this case.

but maybe the correct way to handle this would be to change the advertizing done on tmail-backend side ?

You're right, we forgot to add the new capabilities classes to the capabilities converter so it didn't parse correctly. We've fixed that, see the commits for details.

dab246 · 2025-02-03T09:46:06Z

Nothing happens when click "Contact support" on web

Screen.Recording.2025-02-03.at.14.38.42.mov

Fixed

florentos17 · 2025-02-03T12:18:58Z

We've fixed that, see the commits for details.

yes, thank you for the changes !

dab246 · 2025-02-04T05:09:53Z

Demo

Web:

Screen.Recording.2025-02-04.at.12.03.26.mov

Mobile:

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-02-04.at.12.09.15.mp4

The merge-base changed after approval.

…as a `DefaultCapability` and a cast is necessary

Signed-off-by: dab246 <[email protected]>

…pabilities Signed-off-by: dab246 <[email protected]>

Signed-off-by: dab246 <[email protected]>

…is not empty Signed-off-by: dab246 <[email protected]>

dab246 · 2025-02-06T07:31:44Z

@florentos17 Please don't force push! You lost the commits I fixed for you. I'll update it. Please don't do anything. Thanks

florentos17 · 2025-02-06T08:07:34Z

I only force pushed because dat pham's force push on master added many commits on this branch so I removed those, but your 4 commits are still here ? I'm very sorry if I lost anything, it wasnt intentional.

Signed-off-by: dab246 <[email protected]>

dab246 · 2025-02-06T08:26:05Z

I only force pushed because dat pham's force push on master added many commits on this branch so I removed those, but your 4 commits are still here ? I'm very sorry if I lost anything, it wasnt intentional.

Okay. Everything is fine, I fixed it.

hoangdat · 2025-02-10T11:04:27Z

lib/features/home/data/datasource_impl/session_datasource_impl.dart

@@ -13,7 +14,9 @@ class SessionDataSourceImpl extends SessionDataSource {
  @override
  Future<Session> getSession() {
    return Future.sync(() async {
-      return await _sessionAPI.getSession();
+      return await _sessionAPI.getSession(
+        converters: SessionExtensions.customMapCapabilitiesConverter,


we should add defaultConverter too?

florentos17 temporarily deployed to PR-3452 January 24, 2025 16:29 — with GitHub Actions Inactive

florentos17 temporarily deployed to PR-3452 January 24, 2025 16:39 — with GitHub Actions Inactive

florentos17 self-assigned this Jan 27, 2025

florentos17 temporarily deployed to PR-3452 January 28, 2025 13:19 — with GitHub Actions Inactive

florentos17 temporarily deployed to PR-3452 January 28, 2025 15:43 — with GitHub Actions Inactive

florentos17 temporarily deployed to PR-3452 January 28, 2025 15:55 — with GitHub Actions Inactive

chibenwa previously approved these changes Jan 29, 2025

View reviewed changes

florentos17 dismissed chibenwa’s stale review via 23970e9 January 31, 2025 13:02

florentos17 force-pushed the HTTP-Support-Link-Not-Handled branch from 4a4c3b5 to 23970e9 Compare January 31, 2025 13:02

florentos17 temporarily deployed to PR-3452 January 31, 2025 13:02 — with GitHub Actions Inactive

dab246 reviewed Feb 3, 2025

View reviewed changes

lib/features/home/domain/extensions/session_extensions.dart Outdated Show resolved Hide resolved

dab246 reviewed Feb 3, 2025

View reviewed changes

lib/features/manage_account/presentation/menu/manage_account_menu_view.dart Outdated Show resolved Hide resolved

dab246 temporarily deployed to PR-3452 February 3, 2025 08:41 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3452 February 3, 2025 08:51 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3452 February 3, 2025 09:41 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-3452 February 4, 2025 05:09 — with GitHub Actions Inactive

dab246 previously approved these changes Feb 4, 2025

View reviewed changes

tddang-linagora previously approved these changes Feb 4, 2025

View reviewed changes

hoangdat force-pushed the master branch from 050a885 to 29e8fa7 Compare February 5, 2025 11:06

florentos17 and others added 6 commits February 5, 2025 15:50

display a Contact support setting option when supported by the server

c9cbcd2

fixed buggy getContactSupportCapability: some servers advertize it …

d8c1f2f

…as a `DefaultCapability` and a cast is necessary

Use custom mapCapabilitiesConverter to apply some outside capabilities

c6eaf2b

Signed-off-by: dab246 <[email protected]>

fixup! Use custom mapCapabilitiesConverter to apply some outside ca…

52e67f4

…pabilities Signed-off-by: dab246 <[email protected]>

Open new tab when contact support has mail address at setting view

ad4f615

Signed-off-by: dab246 <[email protected]>

Only display contact support when httpLink or supportMailAddress …

440aea9

…is not empty Signed-off-by: dab246 <[email protected]>

florentos17 force-pushed the HTTP-Support-Link-Not-Handled branch from 0685429 to 440aea9 Compare February 5, 2025 15:06

florentos17 temporarily deployed to PR-3452 February 5, 2025 15:06 — with GitHub Actions Inactive

Handle contact support on mobile

4fcf603

Signed-off-by: dab246 <[email protected]>

dab246 deployed to PR-3452 February 6, 2025 08:26 — with GitHub Actions View deployment

dab246 approved these changes Feb 6, 2025

View reviewed changes

tddang-linagora approved these changes Feb 6, 2025

View reviewed changes

dab246 added the customer label Feb 7, 2025

hoangdat reviewed Feb 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

contact support setting option #3452

contact support setting option #3452

florentos17 commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

chibenwa commented Jan 24, 2025

chibenwa commented Jan 28, 2025

florentos17 commented Jan 28, 2025

florentos17 commented Jan 31, 2025 •

edited

Loading

tddang-linagora commented Feb 3, 2025 •

edited by dab246

Loading

dab246 commented Feb 3, 2025

dab246 commented Feb 3, 2025

florentos17 commented Feb 3, 2025

dab246 commented Feb 4, 2025

dab246 commented Feb 6, 2025

florentos17 commented Feb 6, 2025

dab246 commented Feb 6, 2025

hoangdat Feb 10, 2025

contact support setting option #3452

Are you sure you want to change the base?

contact support setting option #3452

Conversation

florentos17 commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

chibenwa commented Jan 24, 2025

chibenwa commented Jan 28, 2025

florentos17 commented Jan 28, 2025

florentos17 commented Jan 31, 2025 • edited Loading

tddang-linagora commented Feb 3, 2025 • edited by dab246 Loading

dab246 commented Feb 3, 2025

dab246 commented Feb 3, 2025

florentos17 commented Feb 3, 2025

dab246 commented Feb 4, 2025

Demo

dab246 commented Feb 6, 2025

florentos17 commented Feb 6, 2025

dab246 commented Feb 6, 2025

hoangdat Feb 10, 2025

Choose a reason for hiding this comment

florentos17 commented Jan 31, 2025 •

edited

Loading

tddang-linagora commented Feb 3, 2025 •

edited by dab246

Loading