TF-3260 Appgrid the right way #3329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3329. |
dab246
force-pushed
the
improvement/tf-3260-appgrid-the-right-way
branch
from
6c2bccb to
e38afd9
Compare
|
Integration-test for this with back-end image |
|
Should be teestable on jmap.linagora.com |
dab246
force-pushed
the
improvement/tf-3260-appgrid-the-right-way
branch
2 times, most recently
from
ef40045 to
23edb4e
Compare
Done. demo.webm |
Hi @chibenwa . I perform request to
|
tddang-linagora
previously approved these changes
Dec 12, 2024
Screen_recording_20241216_142616.webm |
hoangdat
reviewed
Dec 17, 2024
core/lib/utils/string_convert.dart
Outdated
| @@ -20,4 +20,8 @@ class StringConvert { | |||
| return text; | |||
| } | |||
| } | |||
|
|
|||
| static String toUrlScheme(String hotScheme) { | |||
There was a problem hiding this comment.
Suggested change
| static String toUrlScheme(String hotScheme) { | |
| static String toUrlScheme(String hostScheme) { |
dab246
force-pushed
the
improvement/tf-3260-appgrid-the-right-way
branch
from
23edb4e to
fbeb852
Compare
tddang-linagora
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3260
Resolved
demo-android.webm
ScreenRecording_12-09-2024.12-19-03_1.MP4
demo.webm