-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3264 Fix composer drag drop all modes #3279
Merged
hoangdat
merged 2 commits into
master
from
fixbug/TF-3264-regression-composer-drag-drop
Nov 28, 2024
Merged
TF-3264 Fix composer drag drop all modes #3279
hoangdat
merged 2 commits into
master
from
fixbug/TF-3264-regression-composer-drag-drop
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tddang-linagora
temporarily deployed
to
PR-3279
November 18, 2024 04:43 — with
GitHub Actions
Inactive
This PR has been deployed to https://linagora.github.io/tmail-flutter/3279. |
Screen.Recording.2024-11-18.at.19.02.10.mov |
tddang-linagora
had a problem deploying
to
PR-3279
November 19, 2024 03:11 — with
GitHub Actions
Failure
Please check again. |
tddang-linagora
temporarily deployed
to
PR-3279
November 19, 2024 04:13 — with
GitHub Actions
Inactive
Screen.Recording.2024-11-19.at.14.32.05.mov |
tddang-linagora
temporarily deployed
to
PR-3279
November 20, 2024 08:39 — with
GitHub Actions
Inactive
More fix added. Please check again. |
tddang-linagora
had a problem deploying
to
PR-3279
November 25, 2024 04:51 — with
GitHub Actions
Failure
tddang-linagora
had a problem deploying
to
PR-3279
November 25, 2024 07:45 — with
GitHub Actions
Failure
tddang-linagora
had a problem deploying
to
PR-3279
November 25, 2024 07:51 — with
GitHub Actions
Failure
|
tddang-linagora
force-pushed
the
fixbug/TF-3264-regression-composer-drag-drop
branch
from
November 25, 2024 08:18
ef74f61
to
3ac6317
Compare
tddang-linagora
temporarily deployed
to
PR-3279
November 25, 2024 08:18 — with
GitHub Actions
Inactive
dab246
previously approved these changes
Nov 26, 2024
hoangdat
previously approved these changes
Nov 28, 2024
hoangdat
force-pushed
the
fixbug/TF-3264-regression-composer-drag-drop
branch
from
November 28, 2024 09:36
273a4aa
to
d8b7e50
Compare
hoangdat
approved these changes
Nov 28, 2024
39 tasks
tddang-linagora
added a commit
that referenced
this pull request
Jan 6, 2025
hoangdat
pushed a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Root cause
MobileResponsiveContainerView/DesktopResponsiveContainerView/TabletResponsiveContainerView
'schildBuilder
is rebuilt, causingHtmlEditor
builds from scratch, including runninginitState
method again.ComposerController
is alive throughout the rebuilds, causing the callbacks ofHtmlEditor
to break.Dependency
Resolved
Screen.Recording.2024-11-18.at.11.39.43.mov