Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3264 Fix composer drag drop all modes #3279

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Nov 18, 2024

Issue

Root cause

  • Everytime ComposerView changes according to responsive size/display mode, all of MobileResponsiveContainerView/DesktopResponsiveContainerView/TabletResponsiveContainerView's childBuilder is rebuilt, causing HtmlEditor builds from scratch, including running initState method again.
  • However, ComposerController is alive throughout the rebuilds, causing the callbacks of HtmlEditor to break.

Dependency

Resolved

Screen.Recording.2024-11-18.at.11.39.43.mov

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3279.

@dab246
Copy link
Member

dab246 commented Nov 18, 2024

  • It's still really buggy, we should investigate the html onDrag or onDrop events in composer.
Screen.Recording.2024-11-18.at.19.02.10.mov

@tddang-linagora
Copy link
Contributor Author

It's still really buggy, we should investigate the html onDrag or onDrop events in composer.

Please check again.

@dab246
Copy link
Member

dab246 commented Nov 19, 2024

  • It's not working perfectly yet. Error case: Open long email -> reply to it -> enter text -> zoom in/out 1-2 times -> then drag the file in
Screen.Recording.2024-11-19.at.14.32.05.mov

@tddang-linagora
Copy link
Contributor Author

It's not working perfectly yet.

More fix added. Please check again.

@dab246
Copy link
Member

dab246 commented Nov 25, 2024

  • Please check build CI failed & rebase it.

@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3264-regression-composer-drag-drop branch from ef74f61 to 3ac6317 Compare November 25, 2024 08:18
dab246
dab246 previously approved these changes Nov 26, 2024
hoangdat
hoangdat previously approved these changes Nov 28, 2024
@hoangdat hoangdat merged commit 2128a6e into master Nov 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants