Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3034 Prevent duplicate draft warning #3184

Merged
merged 2 commits into from
Oct 7, 2024
Merged

TF-3034 Prevent duplicate draft warning #3184

merged 2 commits into from
Oct 7, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Oct 1, 2024 •
edited
Loading

Issue

Demo

  • Compose new email
Screen.Recording.2024-10-01.at.15.11.24.mov
  • Edting draft email
Screen.Recording.2024-10-01.at.15.13.08.mov

@tddang-linagora tddang-linagora self-assigned this Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3184.

dab246
dab246 reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add demo for mobile

@tddang-linagora tddang-linagora requested a review from dab246 October 2, 2024 03:27
@dab246
Copy link
Member

dab246 commented Oct 2, 2024 •
edited by tddang-linagora
Loading

  • Do not show dialog save as draft when compose from email address or mailto address bar
compose-from-email-address.mov

@dab246
Copy link
Member

dab246 commented Oct 2, 2024 •
edited by tddang-linagora
Loading

  • Open draft email -> click show full screen, minimize -> click close -> auto show dialog save as draft
Screen.Recording.2024-10-02.at.16.12.28.mov

@dab246
Copy link
Member

dab246 commented Oct 2, 2024 •
edited by tddang-linagora
Loading

  • Open draft email -> change subject -> reload page -> click close composer -> do not show dialog save as draft
Screen.Recording.2024-10-02.at.16.17.00.mov

@tddang-linagora
Copy link
Contributor Author

Open draft email -> change subject -> reload page -> click close composer -> do not show dialog save as draft

Reload and Session expired cases are ignored on purpose.

@tddang-linagora
Copy link
Contributor Author

Do not show dialog save as draft when compose from email address or mailto address bar

Emails are automatically filled as expected. That doesn't count as email content changed, just as when you open a draft. I don't see a problem with this.

@tddang-linagora
Copy link
Contributor Author

Open draft email -> click show full screen, minimize -> click close -> auto show dialog save as draft

Will be fixed when #3191 is merged

@tddang-linagora
Copy link
Contributor Author

Do not show dialog save as draft when compose from email address or mailto address bar

Screen.Recording.2024-10-02.at.21.03.07.mov

@tddang-linagora
Copy link
Contributor Author

Open draft email -> change subject -> reload page -> click close composer -> do not show dialog save as draft

Screen.Recording.2024-10-02.at.21.04.56.mov

@dab246
Copy link
Member

dab246 commented Oct 3, 2024

Open draft email -> click show full screen, minimize -> click close -> auto show dialog save as draft

Will be fixed when #3191 is merged

Please add demo for it.

@tddang-linagora
Copy link
Contributor Author

Open draft email -> click show full screen, minimize -> click close -> auto show dialog save as draft

Will be fixed when #3191 is merged

Please add demo for it.

Screen.Recording.2024-10-03.at.10.09.09.mov

@dab246
Copy link
Member

dab246 commented Oct 3, 2024 •
edited by tddang-linagora
Loading

  • Cannot show warning dialog save when: open draft mail -> drag To to Cc -> Click close
Screen.Recording.2024-10-03.at.10.11.55.mov

@dab246
Copy link
Member

dab246 commented Oct 3, 2024 •
edited by tddang-linagora
Loading

  • Warning dialog save always display when: open new composer -> enable read recipient -> click close -> save as draft -> open this draft mail -> click close
Screen.Recording.2024-10-03.at.10.17.36.mov

@tddang-linagora
Copy link
Contributor Author

Cannot show warning dialog save when: open draft mail -> drag To to Cc -> Click close

Screen.Recording.2024-10-03.at.11.59.31.mov

Warning dialog save always display when: open new composer -> enable read recipient -> click close -> save as draft -> open this draft mail -> click close

Screen.Recording.2024-10-03.at.11.58.11.mov

@dab246 dab246 mentioned this pull request Oct 3, 2024
Closed
@dab246
Copy link
Member

dab246 commented Oct 4, 2024 •
edited by tddang-linagora
Loading

  • Please rebase it

@dab246 dab246 mentioned this pull request Oct 4, 2024
Open
@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3034-prevent-duplicate-draft-warning branch from fdafa3c to f611580 Compare October 4, 2024 03:20
@hoangdat
Copy link
Member

hoangdat commented Oct 4, 2024

please rebase

@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3034-prevent-duplicate-draft-warning branch from f203edd to 228c7d2 Compare October 4, 2024 08:24
@dab246
Copy link
Member

dab246 commented Oct 4, 2024 •
edited by tddang-linagora
Loading

  • Please check again warning on CI
Screenshot 2024-10-04 at 17 45 07

@tddang-linagora tddang-linagora requested a review from dab246 October 7, 2024 02:12
@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3034-prevent-duplicate-draft-warning branch from 4eb0d41 to 7f23fc0 Compare October 7, 2024 03:10
@hoangdat hoangdat merged commit b124692 into master Oct 7, 2024
22 checks passed
@hoangdat hoangdat deleted the fixbug/TF-3034-prevent-duplicate-draft-warning branch November 6, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 Awaiting requested review from dab246

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tddang-linagora @dab246 @hoangdat